fix: add missing transaction block on CatalogService
#3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
bug_report
wolf4ood
approved these changes
Dec 1, 2023
jimmarino
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add missing transaction block on
CatalogServiceWhy it does that
To ensure that all the database calls are finalized correctly
Further notes
Streamover cursor all the service will always return only collected iterables and not streams, and the operations will be wrapped by transaction blocks, that will take care of finalizing the connections.Linked Issue(s)
Closes #3640
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.