fix(test): JSON-LD Unit tests fail on Windows #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes comparison of cached file names on Windows machines as described by Barium. In the unit tests for JsonLdExtension the URI is asserted against the value: "file:/tmp/foo/doc.json" but on Windows the value will include the drive name such as: "file:/C:/tmp/foo/doc.json".
The suggested solution of replacing for example
assertThat(cache).containsEntry("http://foo.org/doc.json", new URI("file:/tmp/foo/doc.json"));
with
assertThat(cache).containsEntry("http://foo.org/doc.json", new File("/tmp/foo/doc.json").toURI());
was implmeented and verified on windows machine
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
rohrbachd
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3670 +/- ##
=======================================
Coverage 71.68% 71.68%
=======================================
Files 916 916
Lines 18416 18416
Branches 1043 1043
=======================================
Hits 13201 13201
Misses 4757 4757
Partials 458 458 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Fixes issue JSON-LD Unit tests fail on Windows #3408
The URI is asserted against the value: "file:/tmp/foo/doc.json" but on Windows the value will include the drive name such as: "file:/C:/tmp/foo/doc.json".
Implemented suggested fix to replace:
assertThat(cache).containsEntry("http://foo.org/doc.json", new URI("file:/tmp/foo/doc.json"));With:
assertThat(cache).containsEntry("http://foo.org/doc.json", new File("/tmp/foo/doc.json").toURI());Why it does that
If not fixed the bug prevents building connector with extensions on Windows systems.
Linked Issue(s)
Closes #3408