Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only pass base URL for the CredentialService #3666

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR changes the url that is passed into the CredentialServiceClient to be just the base URL, as opposed to: the URL including the query endpoint.

Why it does that

Typically, these URLs are resolved from DIDs, that only should contain the base URL, because the actual endpoint is an implementation detail, that does not affect the DID.
For example, a bump in the API version would then cause all DIDs to be regenerated, which is nonsense.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 13 milestone Nov 28, 2023
@paullatzelsperger paullatzelsperger added dcp breaking-change Will require manual intervention for version update labels Nov 28, 2023
@paullatzelsperger paullatzelsperger added the bug Something isn't working label Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad100a6) 71.68% compared to head (91bb15b) 71.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3666   +/-   ##
=======================================
  Coverage   71.68%   71.68%           
=======================================
  Files         916      916           
  Lines       18415    18416    +1     
  Branches     1043     1043           
=======================================
+ Hits        13200    13201    +1     
  Misses       4757     4757           
  Partials      458      458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit cd9dbec into eclipse-edc:main Nov 28, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update bug Something isn't working dcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants