docs: decision record about Protocol Services refactor #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
docs/dr_refactor_protocol_services
branch
from
2250a2d to
9468e71
Compare
jimmarino
approved these changes
Nov 27, 2023
docs/developer/decision-records/2023-11-27-refactor-protocol-services/README.md
Outdated
Show resolved
Hide resolved
…ervices/README.md Co-authored-by: Jim Marino <[email protected]>
ndr-brt
approved these changes
Nov 28, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a Decision Record about moving the security checks (
IdentityService#verifyJwtToken) from the DSP layerto the protocol service layer.
Why it does that
This refactor will allow us to attach contextual information of the current DSP request that can be used in
IdentityServiceimplementations.Linked Issue(s)
Relates #3662
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.