fix: add missing type transformer registrations #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
approved these changes
Nov 24, 2023
paullatzelsperger
force-pushed
the
fix/3648_register_all_transformers
branch
from
4882f88 to
87dcf88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
==========================================
+ Coverage 71.74% 71.85% +0.11%
==========================================
Files 915 916 +1
Lines 18342 18361 +19
Branches 1040 1041 +1
==========================================
+ Hits 13159 13194 +35
+ Misses 4727 4710 -17
- Partials 456 457 +1 ☔ View full report in Codecov by Sentry. |
ndr-brt
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds missing type transformer registrations
Why it does that
Well... they were missing.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #3648
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.