refactor: separate DataPlaneClient
and DataPlaneSelector
#3641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
extract selection feature from the
DataPlaneClient
componentWhy it does that
preparatory refactoring for the issue #3631 , this way the
DataPlaneSelectorService
is directly used by theProviderPushTransferDataFlowController
that can use it to get the available transfer types. This way there's also a match with theConsumerPullTransferDataFlowController
, that also has the selector service as collaborator.Further notes
DataPlaneSelectorClient
into theDataPlaneSelectorService
, as they were doing the same thing. now theEmbeddedDataPlaneSelectorClient
is the default implementation used by the api controller, and theRemote
implementation can be used whenever the selector is deployed separately through theclient
module.DataPlaneSelector
as well, as it was doing nothing that couldn't be done easily by theEmbeddedDataPlaneSelectorService
Linked Issue(s)
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.