feat: bring back the custom DataSink overload #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rc/main/java/org/eclipse/edc/connector/dataplane/framework/manager/DataPlaneManagerImpl.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3627 +/- ##
==========================================
- Coverage 71.78% 71.76% -0.03%
==========================================
Files 909 909
Lines 18134 18144 +10
Branches 1033 1033
==========================================
+ Hits 13018 13021 +3
- Misses 4672 4679 +7
Partials 444 444 ☔ View full report in Codecov by Sentry. |
jimmarino
approved these changes
Nov 17, 2023
paullatzelsperger
force-pushed
the
feat/bring_back_custom_sink
branch
4 times, most recently
from
3d5ccc9 to
85e86c1
Compare
paullatzelsperger
force-pushed
the
feat/bring_back_custom_sink
branch
from
85e86c1 to
5dbf964
Compare
ndr-brt
approved these changes
Nov 20, 2023
| * @param sink The data sink that will receive the transferred data. | ||
| * @return A CompletableFuture wrapping a StreamResult indicating the success or failure of the transfer. | ||
| */ | ||
| CompletableFuture<StreamResult<Object>> transfer(DataFlowRequest request, DataSink sink); |
There was a problem hiding this comment.
Shouldn't this be moved down on PipelineService interface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR brings back the overloaded method in the
DataPlaneManagerthat takes aDataSinkparameter.If specified, the
DataPlaneManager(Impl) will immediately delegate to thePipelineService.This effectively restores the behaviour before #3486
Why it does that
For streaming, e.g. HTTP, we need to be able to supply just any random data sink
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.