-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make VP request to CredentialService #3618
feat: make VP request to CredentialService #3618
Conversation
...ain/java/org/eclipse/edc/iam/identitytrust/core/defaults/DefaultCredentialServiceClient.java
Fixed
Show fixed
Hide fixed
...ain/java/org/eclipse/edc/iam/identitytrust/core/defaults/DefaultCredentialServiceClient.java
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ava/org/eclipse/edc/iam/identitytrust/transform/to/JwtToVerifiableCredentialTransformer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/edc/iam/identitytrust/core/defaults/DefaultCredentialServiceClient.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3618 +/- ##
==========================================
+ Coverage 71.74% 71.83% +0.09%
==========================================
Files 909 913 +4
Lines 18084 18267 +183
Branches 1021 1039 +18
==========================================
+ Hits 12975 13123 +148
- Misses 4666 4694 +28
- Partials 443 450 +7 ☔ View full report in Codecov by Sentry. |
What this PR changes/adds
This PR adds the
DefaultCredentialServiceClient
, which is used to make VP requests against a CredentialService to obtain VPs.In addition, this PR adds a
JwtToVerifiableCredentialTransformer
and aJwtToVerifiablePresentationTransformer
, as they didn't exist up until now.Why it does that
IATP implementation
Further notes
Linked Issue(s)
Closes #3495
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.