feat: Remove duplicate information in the initiate negotiation api request #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without icreasing the api version.
tuncaytunc-zf
added
enhancement
ndr-brt
reviewed
Nov 14, 2023
...se/edc/connector/api/management/contractnegotiation/validation/ContractRequestValidator.java
Show resolved
Hide resolved
...ava/org/eclipse/edc/connector/api/management/contractnegotiation/ContractNegotiationApi.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 72.10% 71.75% -0.36%
==========================================
Files 897 909 +12
Lines 17919 18107 +188
Branches 1018 1027 +9
==========================================
+ Hits 12920 12992 +72
- Misses 4562 4672 +110
- Partials 437 443 +6 ☔ View full report in Codecov by Sentry. |
ndr-brt
requested changes
Nov 15, 2023
tuncaytunc-zf
force-pushed
the
feat/negotiationApiEnhancement
branch
from
c14cacf to
af64854
Compare
ndr-brt
reviewed
Nov 15, 2023
...ava/org/eclipse/edc/connector/api/management/contractnegotiation/ContractNegotiationApi.java
Show resolved
Hide resolved
ndr-brt
requested changes
Nov 16, 2023
...ava/org/eclipse/edc/connector/api/management/contractnegotiation/ContractNegotiationApi.java
Outdated
Show resolved
Hide resolved
…on-api/src/main/java/org/eclipse/edc/connector/api/management/contractnegotiation/ContractNegotiationApi.java Co-authored-by: ndr_brt <[email protected]>
ndr-brt
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes the duplicate information in the initiate negotiation api request without increasing the API version
Why it does that
The offer and the policy have some duplicate values like id and assetId which are representing the same information.
Further notes
The offer will be logged as deprecates to avoid any braking changes
Linked Issue(s)
Closes #3395
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.