-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building with MinGW-w64 toolchain #2093
Open
PatrickM-ZS
wants to merge
1
commit into
eclipse-cyclonedds:master
Choose a base branch
from
PatrickM-ZS:mingw-w64-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support building with MinGW-w64 toolchain #2093
PatrickM-ZS
wants to merge
1
commit into
eclipse-cyclonedds:master
from
PatrickM-ZS:mingw-w64-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake/Modules/Generate.cmake
Outdated
@@ -25,6 +25,12 @@ function(IDLC_GENERATE) | |||
endif() | |||
set(_idlc_depends CycloneDDS::libidlc) | |||
else() | |||
if (CMAKE_HOST_SYSTEM_NAME STREQUAL "Linux" AND NOT ".so" IN_LIST CMAKE_FIND_LIBRARY_SUFFIXES) | |||
# When cross-compiling, find_library looks for libraries using naming onventions of the target, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# When cross-compiling, find_library looks for libraries using naming onventions of the target, | |
# When cross-compiling, find_library looks for libraries using naming conventions of the target, |
In Msys2 the change in src/idl/src/file.h is required for it to build.
Otherwise it fails with this error:
This isn't an issue in the Docker-build, because idlc is compiled natively, I guess. |
Signed-off-by: Patrick Masselink <[email protected]>
PatrickM-ZS
force-pushed
the
mingw-w64-support
branch
from
September 23, 2024 10:05
dbfa8cd
to
d73155d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2051. Thanks to @e-tmplr!
I've added a Dockerfile for Linux with a cross-compile toolchain. It builds, but I've not had much success running the binaries through wine. 32-bit crashes with illegal memory access, 64-bit runs but complains about malformed packets and outputs some gibberish. Maybe due to wine bugs, bad configuration, or perhaps there's something more serious. But that could be fixed on a different PR.