Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regexp in WebTerminalUnderRegularUser #22867

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Change regexp in WebTerminalUnderRegularUser #22867

merged 3 commits into from
Mar 6, 2024

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Mar 6, 2024

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix Empty Workspace PR test failure before the merge:
https://github.com/eclipse/che/actions/runs/8174142878/job/22348238366

Run cd tests/e2e
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=[18](https://github.com/eclipse/che/actions/runs/8174142878/job/22348238366#step:9:19)' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.[19](https://github.com/eclipse/che/actions/runs/8174142878/job/22348238366#step:9:20).4' }
npm WARN EBADENGINE }
npm ERR! code EUSAGE
npm ERR! 
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! Invalid: lock file's chromedriver@1[20](https://github.com/eclipse/che/actions/runs/8174142878/job/22348238366#step:9:21).0.1 does not satisfy chromedriver@1[22](https://github.com/eclipse/che/actions/runs/8174142878/job/22348238366#step:9:23).0.4
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
npm ERR! Missing: [email protected] from lock file
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
npm ERR! Missing: [email protected] from lock file
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: @tootallnate/quickjs-emscripten@0.[23](https://github.com/eclipse/che/actions/runs/8174142878/job/22348238366#step:9:24).0 from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file

@musienko-maxim
Copy link
Contributor Author

Fixed

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@musienko-maxim musienko-maxim merged commit c6982af into main Mar 6, 2024
5 checks passed
@musienko-maxim musienko-maxim deleted the WTO-249 branch March 6, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants