Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change Login, Logout, Stop and delete workspace tests to be hooks (suileSetup, suiteTeardown) #22636

Merged
merged 7 commits into from
Oct 31, 2023
Merged

feat: change Login, Logout, Stop and delete workspace tests to be hooks (suileSetup, suiteTeardown) #22636

merged 7 commits into from
Oct 31, 2023

Conversation

nallikaea
Copy link
Contributor

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 27, 2023
@nallikaea
Copy link
Contributor Author

Trying to run on Jenkins

@nallikaea
Copy link
Contributor Author

https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/13673/consoleFull

@dmytro-ndp
Copy link
Contributor

@nallikaea : while PR looks commonly good, it's strange to see [ERROR] CheReporter runner.on.fail: "Start workspace with existed workspace name" test PSI online-ocp 4.14 Stop created workspace failed after 35380ms [1]:

  • there is workspace remained existed which means removal through API failed;
  • I would ignore stop / delete workspace by API error - just log error message, but not fail test results additionally, and don't save screenshot

[1] https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/13673/artifact/test-repo/tests/e2e/report/Start_workspace_with_existed_workspace_name_test_PSI_online-ocp_4.14_Stop_created_workspace/screenshot-Stop_created_workspace.png

@nallikaea
Copy link
Contributor Author

@dmytro-ndp fixed

@nallikaea nallikaea force-pushed the 22587 branch 2 times, most recently from 883e7d9 to f2e5273 Compare October 30, 2023 06:44
@nallikaea
Copy link
Contributor Author

@dmytro-ndp run wih fixups https://reportportal-crw.apps.ocp-c1.prod.psi.redhat.com/ui/#devspaces/launches/all/155

@nallikaea nallikaea force-pushed the 22587 branch 5 times, most recently from 492fe05 to ef92172 Compare October 30, 2023 11:49
@nallikaea
Copy link
Contributor Author

nallikaea commented Oct 31, 2023 •
edited
Loading

Following issue: #22639

@nallikaea
Copy link
Contributor Author

https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/13892/

dmytro-ndp
dmytro-ndp approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for various fixes, @nallikaea !

PR looks gooks to merge.
I will open followup issue to deal with Failed to send log. Error: Item with tempId "undefined" not found error (test run https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/13898/ )

P.S.: an issue: #22648

@nallikaea
Copy link
Contributor Author

Thank you, @dmytro-ndp 😊

@nallikaea nallikaea merged commit af784fc into eclipse-che:main Oct 31, 2023
2 checks passed
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 31, 2023
@dmytro-ndp dmytro-ndp mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt

@ScrewTSW ScrewTSW Awaiting requested review from ScrewTSW

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Login, Logout, Stop and delete workspace tests to be hooks (suileSetup, suiteTeardown)
3 participants
@nallikaea @dmytro-ndp @che-bot