Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logging with attachments into ReportPortal #22621

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

nallikaea
Copy link
Contributor

@nallikaea nallikaea commented Oct 23, 2023

What does this PR do?

  • PR updates Logger class to send logs into report-portal service using external API.
  • Added method which will send attachment on test fail

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

#22586

How to test this PR?

set SAVE_RP_REPORT_DATA=true, fill relevant reporter constants to set server and user for saving the report. Run some tests.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Oct 23, 2023
@nallikaea nallikaea linked an issue Oct 23, 2023 that may be closed by this pull request
@nallikaea nallikaea changed the title peportportal logger feat: Add logging with attachments into ReportPortal Oct 23, 2023
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Oct 25, 2023

@nallikaea : is this PR ready for verification?

Should it work if I run this PR tests against Dev Spaces with the next list of parameters:

docker run --shm-size=4096m -p 5920:5920 \
 -e TS_SELENIUM_LOAD_PAGE_TIMEOUT=420000 \
 -e TS_SELENIUM_BASE_URL=https://devspaces.apps.ocp414.crw-qe.com/ \
 -e DELETE_WORKSPACE_ON_FAILED_TEST=true \
 -e TS_SELENIUM_START_WORKSPACE_TIMEOUT=120000 \
 -e NODE_TLS_REJECT_UNAUTHORIZED=0 \
 -e VIDEO_RECORDING=true \
 -e E2E_OCP_CLUSTER_API_URL=https://api.ocp414.crw-qe.com:6443/ \
 -e TS_SELENIUM_LOG_LEVEL=TRACE \
 -e TS_WAIT_LOADER_PRESENCE_TIMEOUT=120000 \
 -e TS_COMMON_DASHBOARD_WAIT_TIMEOUT=30000 \
 -e OCP_INFRA=PSI \
 -e OCP_VERSION=4.14 \
 -v /tmp:/usr/local/bin:Z \
 -v /home/hudson/.kube:/home/seluser/.kube:Z \
 -v /mnt/hudson_workspace/workspace/Testing/e2e/basic/typescript-tests/test-repo/tests/e2e:/tmp/e2e:Z \
 -v /mnt/hudson_workspace/workspace/Testing/e2e/basic/typescript-tests/test-repo/tests/e2e/video:/tmp/ffmpeg_report:Z \
 -e SAVE_RP_REPORT_DATA=true \
 -e TEST_SUITE=functional-test-suite \
 -e TS_SELENIUM_OCP_USERNAME=******** \
 -e TS_SELENIUM_OCP_PASSWORD=********* \
 -e SAVE_RP_REPORT_DATA=true \
 -e RP_IS_LOCAL_SERVER=false \
 -e RP_USE_PERSONAL=false \
 -e RP_API_KEY=****************  quay.io/eclipse/che-e2e:next

@che-bot che-bot added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 25, 2023
@nallikaea nallikaea force-pushed the 22543-peportportal-logger branch from 7d3f71d to c22e454 Compare October 26, 2023 09:36
@nallikaea
Copy link
Contributor Author

@dmytro-ndp , yes, I rebased it

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Oct 26, 2023

@nallikaea : thank you.

Need your help to find attachments after the test execution in ReportPortal.

E.g. "Check if recommended extensions installed for Java 11 with Lombok PSI online-ocp 4.14 > Check if extensions are installed and enabled" test failed:

@nallikaea
Copy link
Contributor Author

@dmytro-ndp
Copy link
Contributor

@nallikaea : thank you for the link.

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@nallikaea nallikaea merged commit 95f5f91 into eclipse-che:main Oct 27, 2023
2 checks passed
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging with attachments into ReportPortal
3 participants