-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add logging with attachments into ReportPortal #22621
feat: Add logging with attachments into ReportPortal #22621
Conversation
Signed-off-by: mdolhalo <[email protected]>
Signed-off-by: mdolhalo <[email protected]>
Signed-off-by: mdolhalo <[email protected]>
@nallikaea : is this PR ready for verification? Should it work if I run this PR tests against Dev Spaces with the next list of parameters:
|
Signed-off-by: mdolhalo <[email protected]>
7d3f71d
to
c22e454
Compare
@dmytro-ndp , yes, I rebased it |
@nallikaea : thank you. Need your help to find attachments after the test execution in ReportPortal. E.g. "Check if recommended extensions installed for Java 11 with Lombok PSI online-ocp 4.14 > Check if extensions are installed and enabled" test failed:
|
@nallikaea : thank you for the link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#22586
How to test this PR?
set SAVE_RP_REPORT_DATA=true, fill relevant reporter constants to set server and user for saving the report. Run some tests.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.