CRW-4864 Make 'Check the project files were imported' test in Che test framework not use view section name #22565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallikaea
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
status/code-review
nallikaea
changed the title
nallikaea
force-pushed
the
crw-4864
branch
2 times, most recently
from
a49cec7 to
3f8ee19
Compare
Signed-off-by: mdolhalo <[email protected]>
musienko-maxim
approved these changes
Sep 29, 2023
dmytro-ndp
reviewed
Sep 29, 2023
dmytro-ndp
reviewed
Sep 29, 2023
dmytro-ndp
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
can be merge even though there are non-critical notices added during the review
Good job, @nallikaea
|
Looks good to merge |
artaleks9
approved these changes
Sep 29, 2023
Signed-off-by: mdolhalo <[email protected]>
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes test issue Make 'Check the project files were imported' test in Che test framework not use view section name
Screenshot/screencast of this PR
https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/12418/
What issues does this PR fix or reference?
CRW-4864
How to test this PR?
export USERSTORY=Quarkus && npm run test
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.