Updating go (to match Dockerfile) and golang.org/x/net #1772
Conversation
SDawley
requested review from
nickboldt,
tolusha,
ibuziuk and
l0rd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1772 +/- ##
=======================================
Coverage 59.50% 59.50%
=======================================
Files 71 71
Lines 8592 8592
=======================================
Hits 5113 5113
Misses 3129 3129
Partials 350 350 |
|
@SDawley |
|
Both |
|
@SDawley: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
failing tests appear to be:
- formatting change to add more spaces in comments
- formatting change to add more spaces in comments
- 71 of 73 prow tests passed; the other two timed out, as they like to do.
Therefore +1 to merge this.
Note too that https://github.com/eclipse-che/che-operator/blob/main/Dockerfile#L13 is already using go 1.19.13.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt, SDawley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change-Id: I6280c8b6851d83ec69d7d9898ae48ae583dc2dfe Signed-off-by: Nick Boldt <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
Build 3.11 :: operator_3.x/312: Console, Changes, Git Data |
|
Build 3.10 :: operator_3.10/7: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5147: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.10/81: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3573: Console, Changes, Git Data |
|
Build 3.10 :: push-latest-container-to-quay_3.10/45: Console, Changes, Git Data |
|
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5011: devspaces-operator : 3.x :: Build 56651829 : quay.io/devspaces/devspaces-rhel8-operator:3.11-4 |
|
Build 3.11 :: operator-bundle_3.x/2245: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5152: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3578: Console, Changes, Git Data |
|
Build 3.11 :: copyIIBsToQuay/2050: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5152: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5018 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.11 :: operator-bundle_3.x/2245: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5152 triggered |
|
Build 3.11 :: dsc_3.x/1511: Console, Changes, Git Data |
|
Build 3.11 :: operator-bundle_3.x/2246: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5154: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3580: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5154: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5029 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.11 :: operator-bundle_3.x/2246: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5154 triggered |
|
Build 3.11 :: copyIIBsToQuay/2065: Console, Changes, Git Data |
|
Build 3.11 :: dsc_3.x/1512: Console, Changes, Git Data |
|
Build 3.10 :: operator-bundle_3.10/29: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.10/86: Console, Changes, Git Data |
|
Build 3.10 :: push-latest-container-to-quay_3.10/50: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.10/86: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.10/85 triggered; /job/DS_CI/job/dsc_3.10 triggered; |
|
Build 3.10 :: operator-bundle_3.10/29: Upstream sync done; /DS_CI/sync-to-downstream_3.10/86 triggered |
|
Build 3.10 :: copyIIBsToQuay/2069: Console, Changes, Git Data |
|
Build 3.10 :: dsc_3.10/20: Console, Changes, Git Data |
What does this PR do?
Dockerfile uses go 1.19.13, but go mod file still said go 18, updating to match.
Should resolve CRW-3891 and CRW-3618 (technically already done I guess).
Updating golang.org/x/net for CRW-4654
How to test this PR?
Built the Dockerfile locally
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.