Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Apply editor configurations from a ConfigMap #2841

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Dec 16, 2024

What does this pull request change?

Adds a page that contains steps how to apply editor configurations using a ConfigMap.

image image image

What issues does this pull request fix or reference?

It was done for the https://issues.redhat.com/browse/CRW-7258.
PR in the Che-Code: che-incubator/che-code#460

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Copy link

github-actions bot commented Dec 16, 2024

🎊 Navigate the preview: https://677812a08b0d2350b83b1dae--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Dec 16, 2024

Click here to review and test in web IDE: Contribute

@RomanNikitenko RomanNikitenko marked this pull request as ready for review December 16, 2024 13:41
@RomanNikitenko RomanNikitenko requested review from deerskindoll and a team as code owners December 16, 2024 13:41
@RomanNikitenko RomanNikitenko requested a review from svor December 16, 2024 13:41
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of tweaks.

I applied monospace to settings.json and extensions.json but I'm wondering if that was correct. what does the __ stand for?

RomanNikitenko and others added 4 commits December 16, 2024 17:46
…icrosoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <[email protected]>
…icrosoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <[email protected]>
…icrosoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <[email protected]>
…icrosoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <[email protected]>
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Dec 16, 2024

@deerskindoll

what does the __ stand for?

Using this way I selected what sections are expected in the ConfigMap
I don't mind to remove it, if you think it looks better without that formatting, just let me know

I think we should remove it because the names of the sections in ConfigMap don't contain the character. The monospace will serve as highlight.

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RomanNikitenko
Copy link
Member Author

@deerskindoll
I applied your suggestion: d1b0c13

thank you for your review!

@RomanNikitenko RomanNikitenko merged commit a2fe463 into eclipse-che:main Dec 16, 2024
6 checks passed
@RomanNikitenko RomanNikitenko deleted the editor-configs branch December 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants