-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Apply editor configurations from a ConfigMap #2841
docs: Apply editor configurations from a ConfigMap #2841
Conversation
Signed-off-by: RomanNikitenko <[email protected]>
🎊 Navigate the preview: https://677812a08b0d2350b83b1dae--eclipse-che-docs-pr.netlify.app 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of tweaks.
I applied monospace to settings.json and extensions.json but I'm wondering if that was correct. what does the __ stand for?
modules/administration-guide/pages/editor-configurations-for-microsoft-visual-studio-code.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/editor-configurations-for-microsoft-visual-studio-code.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/editor-configurations-for-microsoft-visual-studio-code.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/editor-configurations-for-microsoft-visual-studio-code.adoc
Outdated
Show resolved
Hide resolved
…icrosoft-visual-studio-code.adoc Co-authored-by: Jana Vrbkova <[email protected]>
…icrosoft-visual-studio-code.adoc Co-authored-by: Jana Vrbkova <[email protected]>
…icrosoft-visual-studio-code.adoc Co-authored-by: Jana Vrbkova <[email protected]>
…icrosoft-visual-studio-code.adoc Co-authored-by: Jana Vrbkova <[email protected]>
Using this way I selected what sections are expected in the ConfigMap I think we should remove it because the names of the sections in ConfigMap don't contain the character. The monospace will serve as highlight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: RomanNikitenko <[email protected]>
@deerskindoll thank you for your review! |
What does this pull request change?
Adds a page that contains steps how to apply editor configurations using a ConfigMap.
What issues does this pull request fix or reference?
It was done for the https://issues.redhat.com/browse/CRW-7258.
PR in the Che-Code: che-incubator/che-code#460
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.