Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Advanced authorization #2668

Merged
merged 8 commits into from
Dec 5, 2023
Merged

feat: Advanced authorization #2668

merged 8 commits into from
Dec 5, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 1, 2023

What does this pull request change?

feat: Advanced authorization

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/CRW-4805

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha marked this pull request as ready for review December 1, 2023 13:18
@tolusha tolusha requested review from deerskindoll and a team as code owners December 1, 2023 13:18
@tolusha tolusha requested a review from nickboldt December 1, 2023 13:18
Copy link

github-actions bot commented Dec 1, 2023

🎊 Navigate the preview: https://656dc5e4c564b14cb93463fe--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Dec 1, 2023

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to reorganize the document a bit but first, let's potential style issues.

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

[id="configuring-advanced-authorization"]
= Configuring advanced authorization

You can determine which users and groups are allowed to access {prod-short}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha Should we clarify that this is an OpenShift feature, or this would work on vanilla k8s as well?

Comment on lines +35 to +39
<1> List of users allowed to access {prod}.
<2> List of groups of users allowed to access {prod} (for {ocp} only).
<3> List of users denied access to {prod}.
<4> List of groups of users denied to access {prod} (for {ocp} only).
+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks liks on k8s one can only use allowUsers / denyUsers, whereas allowGroups / denyGroups is OpenShift specific.

@tolusha tolusha merged commit 13c2753 into main Dec 5, 2023
6 checks passed
@tolusha tolusha deleted the CRW-4805 branch December 5, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants