Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enabling npm artifacts repo process update (rhdevdocs-5035) #2640

Merged
merged 18 commits into from
Oct 20, 2023
Merged

fix: enabling npm artifacts repo process update (rhdevdocs-5035) #2640

merged 18 commits into from
Oct 20, 2023

Conversation

deerskindoll
Copy link
Contributor

What does this pull request change?

enabling npm artifacts process update

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-5035

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

🎊 Navigate the preview: https://65322d21185e4f6ed04a7164--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Click here to review and test in web IDE: Contribute

@deerskindoll deerskindoll marked this pull request as ready for review August 16, 2023 08:16
@deerskindoll deerskindoll requested review from rkratky, max-cx and a team as code owners August 16, 2023 08:16
@deerskindoll deerskindoll requested a review from nickboldt August 16, 2023 08:16
@tolusha
Copy link
Contributor

tolusha commented Oct 20, 2023

The correct Secret should look like:

kind: Secret
apiVersion: v1
metadata:
  name: tls-cer
  annotations:
    controller.devfile.io/mount-path: /public-certs
    controller.devfile.io/mount-as: file
  labels:
    controller.devfile.io/mount-to-devworkspace: 'true'
    controller.devfile.io/watch-secret: 'true'
data:
  nexus.cer: >-
    <Base64_encoded_content_of_public_cert>

You can find the template for tests in disconnected environment: https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/resources/disconnected/nexus/tls-nexus-crt.secret.yaml.template

@deerskindoll
Copy link
Contributor Author

deerskindoll commented Oct 20, 2023

The correct Secret should look like:

kind: Secret
apiVersion: v1
metadata:
  name: tls-cer
  annotations:
    controller.devfile.io/mount-path: /public-certs
    controller.devfile.io/mount-as: file
  labels:
    controller.devfile.io/mount-to-devworkspace: 'true'
    controller.devfile.io/watch-secret: 'true'
data:
  nexus.cer: >-
    <Base64_encoded_content_of_public_cert>

You can find the template for tests in disconnected environment: gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/resources/disconnected/nexus/tls-nexus-crt.secret.yaml.template

I checked the preview of the whole page and the secret is described there: https://6531a534185e4f0ce74a6fec--eclipse-che-docs-pr.netlify.app/docs/next/end-user-guide/enabling-npm-artifact-repositories/. UPDATE: Now I see the difference. Let me update it.

@deerskindoll deerskindoll merged commit a545c82 into eclipse-che:main Oct 20, 2023
5 checks passed
@deerskindoll deerskindoll deleted the npm-process-update branch October 20, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants