-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use 'errors.getMessage' to determine error message in AxiosWrapper #958
Conversation
Signed-off-by: David Kwon <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-958 |
@dkwon17: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
@dkwon17 once merged, could you please cherry-pick the fix for 3.10 ? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.10 :: dashboard_3.x/370: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.x/371: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/5032: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/5031: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4870: dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4871: dashboard : 3.x :: Failed in : quay.io/devspaces/dashboard-rhel8:3.10-40 |
Build 3.11 :: dashboard_3.x/372: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5049: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/4886: dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
I noticed that the
Bearer Token Authorization is required
message exists inerr.response.data.message
, rather thanerr.message
:What issues does this PR fix or reference?
Related to 401/403 issues.
Is it tested? How?
Random 401 issues can be simulated by adding this git patch to the dashboard:
When the 401 errors occur, there should be
Retrying request ...
warnings in the console:Release Notes
Docs PR