Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce frontend bundle size #1285

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Reduce frontend bundle size #1285

merged 3 commits into from
Jan 15, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 1, 2025

What does this PR do?

Reduced frontend bundle size by 14 percent of our size.

Screenshot/screencast of this PR

Before

Знімок екрана 2024-12-19 о 18 08 15

After

Знімок екрана 2025-01-01 о 17 50 41

What issues does this PR fix or reference?

fixes eclipse-che/che#23219

@che-bot
Copy link
Contributor

che-bot commented Jan 1, 2025

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 50.64935% with 38 lines in your changes missing coverage. Please review.

Project coverage is 91.69%. Comparing base (e3d2d8d) to head (04e5313).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...rd-frontend/src/components/DevfileViewer/index.tsx 0.00% 23 Missing ⚠️
...oard-frontend/src/components/BasicViewer/index.tsx 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
+ Coverage   91.58%   91.69%   +0.10%     
==========================================
  Files         498      498              
  Lines       45590    45527      -63     
  Branches     3171     3172       +1     
==========================================
- Hits        41754    41746       -8     
+ Misses       3803     3752      -51     
+ Partials       33       29       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4 olexii4 marked this pull request as draft January 2, 2025 09:28
Copy link

github-actions bot commented Jan 2, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

@olexii4 olexii4 marked this pull request as ready for review January 2, 2025 11:16
Copy link

github-actions bot commented Jan 2, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

2 similar comments
Copy link

github-actions bot commented Jan 2, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Jan 2, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Jan 2, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

New changes are detected. LGTM label has been removed.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jan 15, 2025

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-dashboard-happy-path 70f4235 link true /test v14-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]"

@olexii4 olexii4 merged commit dbf085e into main Jan 15, 2025
17 of 19 checks passed
@olexii4 olexii4 deleted the CHE-23219 branch January 15, 2025 16:16
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/616: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8653: FAILURE

dashboard : 3.x :: Failed in 66389471 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Reduce frontend bundle size
5 participants