-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cache the service account token in the devWorkspace client #1283
base: main
Are you sure you want to change the base?
Conversation
packages/dashboard-backend/src/devworkspaceClient/__tests__/index.spec.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/devworkspaceClient/__tests__/index.spec.ts
Outdated
Show resolved
Hide resolved
357ca00
to
87ffc3b
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1283 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1283", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1283 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1283", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
- Coverage 91.85% 91.70% -0.15%
==========================================
Files 499 498 -1
Lines 45654 45590 -64
Branches 3191 3176 -15
==========================================
- Hits 41937 41810 -127
- Misses 3683 3749 +66
+ Partials 34 31 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Remove the
DevWorkspaceSingletonClient
implementation as it caches the service account token. Use theDevWorkspaceClient
with service account token fetch instead.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23230
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-1283
eclipse-che
operator deployment to 0 pods.che-dashboard
deployment to 0 pods.to the
che-dashboard
deployment yaml.che-dashboard
deployment to 1 pod.See: the workspace starts, at least the
Checking for the limit of running workspaces
step passes. The workspace may not start as theche-operator
is turned off. If turn on the operator, the token lifetime will be restored to one year.Release Notes
Docs PR