Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @eclipse-che/che-devworkspace-generator and @devfile/api #1278

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Dec 16, 2024

What does this PR do?

Upgrade @eclipse-che/che-devworkspace-generator and @devfile/api.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23288, eclipse-che/che#23201

Is it tested? How?

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Dec 16, 2024

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 requested review from svor and removed request for ibuziuk and akurinnoy December 16, 2024 17:02
@olexii4 olexii4 requested a review from akurinnoy December 16, 2024 17:10
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1278

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1278", name: che-dashboard}]}}]"

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (6be3790) to head (99b5eb4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
+ Coverage   91.69%   91.75%   +0.06%     
==========================================
  Files         499      500       +1     
  Lines       45651    45676      +25     
  Branches     3178     3177       -1     
==========================================
+ Hits        41860    41912      +52     
+ Misses       3760     3734      -26     
+ Partials       31       30       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should fix this issue as well
eclipse-che/che#23201

@openshift-ci openshift-ci bot removed the lgtm label Dec 17, 2024
Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1278

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1278", name: che-dashboard}]}}]"

@olexii4 olexii4 merged commit 2f614a1 into main Dec 17, 2024
17 of 19 checks passed
@olexii4 olexii4 deleted the CHE-23288 branch December 17, 2024 12:54
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/605: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dashboard dependencies: @eclipse-che/che-devworkspace-generator, @devfile/api
5 participants