-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @eclipse-che/che-devworkspace-generator and @devfile/api #1278
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1278 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1278", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 91.69% 91.75% +0.06%
==========================================
Files 499 500 +1
Lines 45651 45676 +25
Branches 3178 3177 -1
==========================================
+ Hits 41860 41912 +52
+ Misses 3760 3734 -26
+ Partials 31 30 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should fix this issue as well
eclipse-che/che#23201
…vfile/api Signed-off-by: Oleksii Orel <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1278 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1278", name: che-dashboard}]}}]" |
Build 3.19 :: dashboard_3.x/605: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8328: Console, Changes, Git Data |
What does this PR do?
Upgrade @eclipse-che/che-devworkspace-generator and @devfile/api.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23288, eclipse-che/che#23201
Is it tested? How?
Release Notes
Docs PR