-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply attribute to the default configuration devfile #1029
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1029 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1029", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 383 383
Lines 39337 39345 +8
Branches 2617 2617
=======================================
+ Hits 34615 34623 +8
Misses 4697 4697
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Verified on Eclipse Che with dashboard image |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.12 :: dashboard_3.x/435: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5867: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4108: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5734: dashboard : 3.x :: Build 57939010 : quay.io/devspaces/dashboard-rhel8:3.12-15 |
Build 3.12 :: dashboard_3.x/435: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5867 triggered |
Build 3.12 :: update-digests_3.x/5494: Console, Changes, Git Data |
Build 3.12 :: update-digests_3.x/5494: No new images detected: nothing to do! |
What does this PR do?
Fix for #1016
Apply the attribute
controller.devfile.io/bootstrap-devworkspace: true
also when devfile resolution succeded but no devfile found.What issues does this PR fix or reference?
eclipse-che/che#22697
Is it tested? How?