Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply attribute to the default configuration devfile #1029

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jan 2, 2024

What does this PR do?

Fix for #1016

Apply the attribute controller.devfile.io/bootstrap-devworkspace: true also when devfile resolution succeded but no devfile found.

What issues does this PR fix or reference?

eclipse-che/che#22697

Is it tested? How?

  1. Deploy Eclipse Che and the dashboard image from this PR:
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1029", name: che-dashboard}]}}]"
  1. Add your SSH keys to the Dashboard, and make sure the public one is uploaded to your Git provider.
  2. Copy the git+SSH URL of your git repository, and create a new workspace using this URL.
  3. The workspace should start successfully with the project cloned and the Devfile applied.

@akurinnoy akurinnoy self-assigned this Jan 2, 2024
@che-bot
Copy link
Contributor

che-bot commented Jan 2, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Jan 2, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1029

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1029", name: che-dashboard}]}}]"

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c256532) 87.99% compared to head (3745357) 87.99%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         383      383           
  Lines       39337    39345    +8     
  Branches     2617     2617           
=======================================
+ Hits        34615    34623    +8     
  Misses       4697     4697           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artaleks9
Copy link
Contributor

Verified on Eclipse Che with dashboard image quay.io/eclipse/che-dashboard:pr-1029 - works as expected

Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk merged commit e06aa58 into main Jan 9, 2024
17 checks passed
@ibuziuk ibuziuk deleted the resolve-devfile-2 branch January 9, 2024 14:40
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/435: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/435: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5867 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5494: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants