Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed node name duplication in D-Bus API #1018

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Jan 3, 2025

Fixes: #916

The structures returned by the ListUnits and ListUnitFiles API on the Controller interface repeated the node name for each unit (file) entry. This can be reduced by using a dictionary with the node name as key and the unit (file) information in the array.

@engelmi engelmi force-pushed the remove-node-name-duplication branch from 3206456 to a99ae4e Compare January 3, 2025 14:02
@coveralls
Copy link

coveralls commented Jan 3, 2025

Coverage Status

coverage: 82.251% (-0.2%) from 82.426%
when pulling 6c125a8 on engelmi:remove-node-name-duplication
into 1bd96dc on eclipse-bluechi:main.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexlarsson alexlarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the OOM check this looks good to me.

@engelmi engelmi force-pushed the remove-node-name-duplication branch from a99ae4e to db44e17 Compare January 14, 2025 12:01
Fixes: eclipse-bluechi#916

The structures returned by the ListUnits and ListUnitFiles API on
the Controller interface repeated the node name for each unit
(file) entry. This can be reduced by using a dictionary with the
node name as key and the unit (file) information in the array.

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi force-pushed the remove-node-name-duplication branch from db44e17 to 6c125a8 Compare January 14, 2025 15:18
@engelmi engelmi merged commit 1cb7527 into eclipse-bluechi:main Jan 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove node name duplication in the ListUnits and ListUnitFiles API
4 participants