Make inline javascript compatible with CSP #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n:nonce macro is important when CSP is used and only way that direct JS is gona work is with nonce attribute (witch macro provide). It harmless otherwise.
Make javascript compatible with CSP
In nette 3.0 services should be specified with factory not class attribute
Replace parseServices, with loadDefinitionsFromConfig method
|
You should not change package name. Also I do not develop this extension anymore so if you would like to maintain it some may appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n:nonce macro is important when CSP is used and only way that direct JS is gonna work, is with nonce attribute (witch macro provide).
If CSP is not on, it doesn't do anything, so it is no big deal to implement.