Merge pull request #24 from ecency/bugfix/sentry-catches

bugfix/sentry-catches
ecency · Sep 22, 2024 · 9ca33d0 · 9ca33d0
2 parents b04e9df + 874420a
commit 9ca33d0
Show file tree

Hide file tree

Showing 10 changed files with 46 additions and 17 deletions.
diff --git a/next.config.js b/next.config.js
@@ -70,7 +70,7 @@ const withSentry = withSentryConfig(config, {
   // tunnelRoute: "/monitoring",
 
   // Hides source maps from generated client bundles
-  hideSourceMaps: true,
+  hideSourceMaps: false,
 
   // Automatically tree-shake Sentry logger statements to reduce bundle size
   disableLogger: true,

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ecency-vision-next",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "private": true,
   "scripts": {
     "dev": "next dev",

diff --git a/public/sw.js b/public/sw.js
diff --git a/public/sw.js.map b/public/sw.js.map
diff --git a/src/api/mutations/create-reply.ts b/src/api/mutations/create-reply.ts
@@ -32,7 +32,7 @@ export function useCreateReply(entry?: Entry | null, parent?: Entry, onSuccess?:
       point: boolean;
       options?: CommentOptions;
     }) => {
-      if (!activeUser || !activeUser.data.__loaded || !entry) {
+      if (!activeUser || !entry) {
         throw new Error("[Reply][Create] – no active user provided");
       }
 

diff --git a/src/api/mutations/notifications/update-notifications-settings.ts b/src/api/mutations/notifications/update-notifications-settings.ts
@@ -7,20 +7,43 @@ import * as ls from "@/utils/local-storage";
 import { error, success } from "@/features/shared";
 import i18next from "i18next";
 import { formatError } from "@/api/operations";
+import { getAccessToken } from "@/utils";
+import { appAxios } from "@/api/axios";
+import { apiBase } from "@/api/helper";
+import { ApiNotificationSetting } from "@/entities";
 
 export function useUpdateNotificationsSettings() {
   const activeUser = useGlobalStore((state) => state.activeUser);
   const queryClient = useQueryClient();
 
   return useMutation({
     mutationKey: ["notifications", "update-settings"],
-    mutationFn: ({ notifyTypes, isEnabled }: { notifyTypes: NotifyTypes[]; isEnabled: boolean }) =>
-      saveNotificationsSettings(
-        activeUser!.username,
-        notifyTypes,
-        isEnabled,
-        ls.get("fb-notifications-token")
-      ),
+    mutationFn: async ({
+      notifyTypes,
+      isEnabled
+    }: {
+      notifyTypes: NotifyTypes[];
+      isEnabled: boolean;
+    }) => {
+      if (!activeUser?.username) {
+        throw new Error("[UpdateNotificationSettings] Attempted to update settings with anon user");
+      }
+
+      const token = ls.get("fb-notifications-token") ?? "";
+
+      const response = await appAxios.post<ApiNotificationSetting>(
+        apiBase(`/private-api/register-device`),
+        {
+          code: getAccessToken(activeUser.username),
+          username: activeUser.username,
+          token,
+          system: "web",
+          allows_notify: Number(isEnabled),
+          notify_types: notifyTypes
+        }
+      );
+      return response.data;
+    },
     onError: (e) => error(...formatError(e)),
     onSuccess: (settings) => {
       queryClient.setQueryData(

diff --git a/src/api/mutations/update-reply.ts b/src/api/mutations/update-reply.ts
@@ -25,8 +25,8 @@ export function useUpdateReply(entry?: Entry | null, onSuccess?: () => void) {
       point: boolean;
       options?: CommentOptions;
     }) => {
-      if (!activeUser || !activeUser.data.__loaded || !entry) {
-        throw new Error("[Reply][Create] – no active user provided");
+      if (!activeUser || !entry) {
+        throw new Error("[Reply][Update] – no active user provided");
       }
 
       await comment(

diff --git a/src/api/queries/get-discussions-query.ts b/src/api/queries/get-discussions-query.ts
@@ -115,7 +115,7 @@ export const getDiscussionsMapQuery = (entry: Entry | undefined, enabled: boolea
       return {};
     },
     enabled: enabled && !!entry,
-    initialData: {}
+    refetchOnMount: true
   });
 
 export function addReplyToDiscussionsList(

diff --git a/src/app/decks/_components/columns/deck-items/deck-thread-item-body.tsx b/src/app/decks/_components/columns/deck-items/deck-thread-item-body.tsx
@@ -60,7 +60,7 @@ export const DeckThreadItemBody = ({
     });
     renderVideos(renderAreaRef);
     renderTweets(renderAreaRef);
-  }, [entry.parent_author, setRenderInitiated]);
+  }, [entry.parent_author]);
 
   const renderContentBody = useCallback(() => {
     if (entry.parent_author === "liketu.moments") {
@@ -83,7 +83,7 @@ export const DeckThreadItemBody = ({
     if (!renderInitiated) {
       renderBody();
     }
-  }, [height, entry, onResize, renderBody, renderInitiated]);
+  }, [height, entry, renderBody, renderInitiated]);
 
   return (
     <div className="thread-item-body">

diff --git a/src/core/global-store/modules/authentication-module.ts b/src/core/global-store/modules/authentication-module.ts
@@ -6,6 +6,7 @@ import { formatError } from "@/api/operations";
 import { getAccountFullQuery } from "@/api/queries";
 import { activeUserMaker } from "@/specs/test-helper";
 import { ACTIVE_USER_COOKIE_NAME } from "@/consts";
+import * as Sentry from "@sentry/nextjs";
 
 const load = (): ActiveUser | null => {
   const name = ls.get("active_user");
@@ -63,10 +64,15 @@ export const createAuthenticationActions = (
       ls.set("active_user", name);
       Cookies.set(ACTIVE_USER_COOKIE_NAME, name, { expires: 365 });
       set({ activeUser: load() });
+
+      Sentry.setUser({
+        username: name
+      });
     } else {
       ls.remove("active_user");
       Cookies.remove(ACTIVE_USER_COOKIE_NAME);
       set({ activeUser: load() });
+      Sentry.setUser(null);
     }
   }
 });