Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GU-2766 add flash list for performance #2771

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

gamingumar
Copy link
Collaborator

What does this PR?

add flash list for performance improvment

@gamingumar gamingumar requested a review from noumantahir October 5, 2023 08:47
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall basic functionality is working fine... a couple of warnings, there is more stuttering during initial scrolls, but it adjusts after some moments...waves refresh is not working

Initial Stutter
first render, texts are missing, thumbnail is not well sized
Screenshot 2023-10-05 at 2 53 55 PM
adjusts afterwards to this
Screenshot 2023-10-05 at 2 54 13 PM

Error
when attempting to refresh waves
Screenshot 2023-10-05 at 2 59 35 PM

Warnings
Screenshot 2023-10-05 at 2 52 39 PM
Screenshot 2023-10-05 at 2 53 31 PM

@noumantahir
Copy link
Collaborator

fixes #2766

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit ebd3278 into development Oct 6, 2023
@feruzm feruzm deleted the feat/GU-2766-flashlist branch October 6, 2023 08:39
@gamingumar gamingumar mentioned this pull request Oct 9, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants