OffLattice support #453
Merged
OffLattice support #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add add_offlattice() to SpatiocyteWorld instead of add_space()
Add spatiocyte::OffLattice, which stores arguments for creating an instance of OffLatticeSpace
Add Python API for OffLattice
Remove some functions for Particle from VoxelSpaceBase
Remove other functions for Particle from VoxelSpaceBase
Implement VoxelSpaceBase::find_voxel() instead of VoxelSpaceBase::find_particle()
Refactor spatiocyte
Change the return type of SpatiocyteWorld::list_voxels()
Introduce VoxelView and change the return type of VoxelSpaceBase::list_voxels()
Change the argument types of SpatiocyteWorld::update_voxel()
Change the argument types of VoxelSpaceBase::update_voxel()
Fix get_neighbor* and Reactions related to OffLatticeSpace
Add StepEvent::dimension() and lift up StepEvent::walk() to a common function()
Add a model to a python unittest test_constructor
|
Some checks are failing. |
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure
OffLatticeSpaceplays the below functions.and fixes #133 and #430.