fix(default-css): Fixing rules for links inside lists, fixing description list - FRONT-4676 #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion list - FRONT-4676
|
Just to double check here: the description list has an underlined link. This is is the only case in our examples where the link is underlined in a list. Is it on purpose? |
emeryro
reviewed
Nov 13, 2024
| @@ -54,7 +54,7 @@ export const Default = () => ` | |||
| <li>Ordered list</li> | |||
| <li>Ordered list | |||
| <ol> | |||
| <li>Nested ordered list</li> | |||
| <li><a class="ecl-link">Nested ordered list</a></li> | |||
There was a problem hiding this comment.
Suggested change
| <li><a class="ecl-link">Nested ordered list</a></li> | |
| <li><a class="ecl-link" href="#">Nested ordered list</a></li> |
|
mmh..better asking the designers, this was orginated by a request related to unordered and ordered lists, the description list was not touched, i only fixed some styles in the default css |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.