-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: nested NOT_SUPPORTED transaction with an inner REQUIRES transaction #3288
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,8 +28,8 @@ | |
import io.ebeanservice.docstore.api.DocStoreTransaction; | ||
import io.ebeanservice.docstore.api.DocStoreUpdateProcessor; | ||
import io.ebeanservice.docstore.api.DocStoreUpdates; | ||
|
||
import jakarta.persistence.PersistenceException; | ||
|
||
import javax.sql.DataSource; | ||
import java.sql.Connection; | ||
import java.sql.SQLException; | ||
|
@@ -176,13 +176,6 @@ public final SpiTransaction active() { | |
return scopeManager.active(); | ||
} | ||
|
||
/** | ||
* Return the current active transaction as a scoped transaction. | ||
*/ | ||
private ScopedTransaction activeScoped() { | ||
return (ScopedTransaction) scopeManager.active(); | ||
} | ||
|
||
/** | ||
* Return the current transaction from thread local scope. Note that it may be inactive. | ||
*/ | ||
|
@@ -499,7 +492,7 @@ public final ScopedTransaction externalBeginTransaction(SpiTransaction transacti | |
*/ | ||
public final ScopedTransaction beginScopedTransaction(TxScope txScope) { | ||
txScope = initTxScope(txScope); | ||
ScopedTransaction txnContainer = activeScoped(); | ||
ScopedTransaction txnContainer = (ScopedTransaction) inScope(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it possible (or allowed) that we will get an instance not implementing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if a |
||
|
||
boolean setToScope; | ||
boolean nestedSavepoint; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not longer in use