[WIP] Fix return value when get agent hosting pool #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: redmine #9683 Signed-off-by: cheng.tang <[email protected]>
huntxu
reviewed
Apr 1, 2017
| request.context, kwargs['pool_id']) | ||
| if not agent: | ||
| agent = {'agent': []} | ||
| return agent |
There was a problem hiding this comment.
应该到get_lbaas_agent_hosting_pool的实现里面改会比较好，那里的返回比较清晰。
另外agent是个单数，所以应该是{'agent': None}返回成json是{'agent': null}
我不是很熟悉RESTful的东西，感觉确实应该保持一致，建议你先提交到上游看看。如果上游觉得没问题我们也就没必要修复了
There was a problem hiding this comment.
开始也想在里面改,,, 结果一看 有好几个地方都调用了get_lbaas_agent_hosting_pool....
There was a problem hiding this comment.
所以其实是plugin只用了一个函数分别提供给rest的api和对rpc的api的问题，先看看上游是否觉得这个返回值是个bug吧，如果算是再说。
huntxu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: redmine #9683
Signed-off-by: cheng.tang [email protected]