WIP：solve the problem of plug-in deployment failure caused by hyper-converged #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
redmine的信息应该添加到commit message里。个人的signoff也是，用 |
|
学着用git把现在这个pull request里三个commit，变成master之上的一个commit |
armstrong-liu
force-pushed
the
master
branch
from
f2d6ee8 to
1cf10d1
Compare
|
已修改，谢谢你的建议@huntxu。 |
huntxu
reviewed
Sep 12, 2017
| @@ -1,11 +1,11 @@ | |||
| class neutron_qos ( | |||
| $qos_plugin = 'neutron.services.qos.qos_plugin.QosPlugin', | |||
| $node_role = undef, | |||
| $roles = undef, | |||
There was a problem hiding this comment.
噢，这里还有个问题，因为下面用$roles是当作列表判断成员在不在的，所以这里默认值不能是undef，应该需要改成$roles = [],才可以。虽然我们实际使用中未必会不传$roles留空，但为免以后搞不明白，还是修改比较好。
armstrong-liu
force-pushed
the
master
branch
from
1cf10d1 to
057c734
Compare
Feature-implementation: http://192.168.15.2/issues/10931 Signed-off-by: liuzhuangzhuang <[email protected]>
armstrong-liu
force-pushed
the
master
branch
from
057c734 to
8ff384b
Compare
blkart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify scripts to solve the problem of plug-in deployment failure caused by hyper-converged。
Feature-implementation: http://192.168.15.2/issues/10931
Signed-off-by: liuzhuangzhuang [email protected]