-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce #3472 (transfer Bundle requirements to module) but do not create logfile in components #3509
base: develop
Are you sure you want to change the base?
Reintroduce #3472 (transfer Bundle requirements to module) but do not create logfile in components #3509
Conversation
Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
This fixes the increased memory usage when running the EasyConfig test suite as log files would stay open. Signed-off-by: Jan André Reuter <[email protected]>
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 9 out of 19 (10 easyconfigs in total) |
Failures due to #3402 missing.
|
# close log for this component | ||
comp.close_log() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure that this removal is safe. Based on the changes in framework I think it is, as the components just use the log file of the Bundle. Keeping it in doesn't hurt though, as the changes in framework should make sure that only Bundle can close its log and none of the components.
This fixes the increased disk usage when running the EasyConfig test suite as log files would stay open.
See easybuilders/easybuild-easyconfigs#21841 for more information.
Requires:
Related:
See #3472 for the initial review and #3504 for the occurring issue, causing a revert of the PR.