Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take into account that f90wrap_version may be None in MetalWalls easyblock #3468

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Crivella
Copy link
Contributor

@Crivella Crivella commented Oct 3, 2024

Fix exception caused by calling LoosVersion on f90wrap_version even when it is None

@boegel boegel changed the title Bugfix for MetalWalls easyblock take into account that f90wrap_version may be None in MetalWalls easyblock Oct 9, 2024
@boegel boegel added the bug fix label Oct 9, 2024
@boegel boegel added this to the release after 4.9.4 milestone Oct 9, 2024
@boegel
Copy link
Member

boegel commented Oct 9, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="MetalWalls-21.06.1-foss-2023a.eb"

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3468 EB_ARGS="MetalWalls-21.06.1-foss-2023a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3468 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5032

Test results coming soon (I hope)...

- notification for comment with ID 2401392148 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants