Only send heartbeat when necessary

eandersson · Jul 11, 2016 · 12399d9 · 12399d9
1 parent 57677f3
commit 12399d9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/amqpstorm/channel0.py b/amqpstorm/channel0.py
@@ -38,7 +38,7 @@ def on_frame(self, frame_in):
         """
         LOGGER.debug('Frame Received: %s', frame_in.name)
         if frame_in.name == 'Heartbeat':
-            self.send_heartbeat()
+            return
         elif frame_in.name == 'Connection.Start':
             self.server_properties = frame_in.server_properties
             self._send_start_ok_frame(frame_in)

diff --git a/amqpstorm/tests/channel0_tests.py b/amqpstorm/tests/channel0_tests.py
@@ -162,13 +162,8 @@ def test_channel0_heartbeat(self):
         connection = amqpstorm.Connection('localhost', 'guest', 'guest',
                                           lazy=True)
         channel = Channel0(connection)
-
-        self.assertEqual(connection.heartbeat._writes_since_check, 0)
-
         channel.on_frame(Heartbeat())
 
-        self.assertEqual(connection.heartbeat._writes_since_check, 1)
-
     def test_channel0_is_blocked(self):
         connection = amqpstorm.Connection('localhost', 'guest', 'guest',
                                           lazy=True)