Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agent): use new docker types, go upgrade #963

Merged
merged 10 commits into from
Apr 19, 2024
Merged

chore(agent): use new docker types, go upgrade #963

merged 10 commits into from
Apr 19, 2024

Conversation

nandor-magyar
Copy link
Contributor

All the deprecated types in use are migrated, some lint errors are also addressed or excluded.

@nandor-magyar nandor-magyar requested a review from a team as a code owner April 18, 2024 16:49
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:cli The scope of the issue or pull request is CLI tool. lang:golang pr:chore labels Apr 18, 2024
polaroi8d
polaroi8d approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added source:ci Workflow files source:build Makefiles, Dockerfiles, etc labels Apr 19, 2024
@nandor-magyar nandor-magyar force-pushed the chore/agent-docker-type-migration branch from f7099ec to 0d26d47 Compare April 19, 2024 10:58
@nandor-magyar nandor-magyar temporarily deployed to Workflow - Protected April 19, 2024 11:02 — with GitHub Actions Inactive
@nandor-magyar nandor-magyar force-pushed the chore/agent-docker-type-migration branch from 0d26d47 to 50f6477 Compare April 19, 2024 11:08
@nandor-magyar nandor-magyar temporarily deployed to Workflow - Protected April 19, 2024 11:13 — with GitHub Actions Inactive
@nandor-magyar nandor-magyar force-pushed the chore/agent-docker-type-migration branch from 50f6477 to e46f6ff Compare April 19, 2024 11:30
@nandor-magyar nandor-magyar force-pushed the chore/agent-docker-type-migration branch from e46f6ff to 1115d32 Compare April 19, 2024 11:48
@nandor-magyar nandor-magyar temporarily deployed to Workflow - Protected April 19, 2024 11:53 — with GitHub Actions Inactive
polaroi8d
polaroi8d reviewed Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

.golangci.yml Outdated Show resolved Hide resolved
@nandor-magyar nandor-magyar merged commit afd6526 into develop Apr 19, 2024
7 of 8 checks passed
@nandor-magyar nandor-magyar deleted the chore/agent-docker-type-migration branch April 19, 2024 15:40
@nandor-magyar nandor-magyar changed the title chore(agent): use new docker types, make linter happy again chore(agent): use new docker types, go upgrade Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@nandor-magyar nandor-magyar

Labels
lang:golang lang:makefile pr:chore source:agent The scope of the issue or pull request is agent. source:build Makefiles, Dockerfiles, etc source:ci Workflow files source:cli The scope of the issue or pull request is CLI tool.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandor-magyar @polaroi8d