Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agent update image #1017

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: agent update image #1017

merged 2 commits into from
Dec 2, 2024

Conversation

robot9706
Copy link
Contributor

Fix agent install & update always using the latest image instead of the latest possible for the actual dyrectorio version.

@robot9706 robot9706 self-assigned this Nov 25, 2024
@robot9706 robot9706 requested a review from a team as a code owner November 25, 2024 12:38
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript pr:fix labels Nov 25, 2024
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested with multiple versions?

@robot9706
Copy link
Contributor Author

Is this tested with multiple versions?

Yes, originally it worked as expected but the config default latest value overwrote it. We even have a test for it.

@robot9706 robot9706 requested a review from polaroi8d November 27, 2024 12:46
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but w8 for @m8vago or @nandor-magyar for one more review, please.

@m8vago m8vago merged commit 8ab86e7 into develop Dec 2, 2024
26 checks passed
@m8vago m8vago deleted the fix/agent-update-image branch December 2, 2024 09:35
robot9706 added a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:typescript pr:fix source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants