Internal extractor of tar files from buffer #297
reviewdog [cpplint] report
reported by reviewdog 🐶
Findings (21)
src/cjit.c|206| Add #include for fprintf [build/include_what_you_use] [4]
src/file.c|333| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/file.c|369| If you can, use sizeof(filename) instead of 63 as the 2nd arg to snprintf. [runtime/printf] [3]
src/file.c|387| If you can, use sizeof(tpath) instead of 259 as the 2nd arg to snprintf. [runtime/printf] [3]
src/file.c|387| Add #include for snprintf [build/include_what_you_use] [4]
src/muntar.c|177| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/muntar.c|192| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/muntar.c|198| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/muntar.c|215| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/muntar.c|221| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/muntar.c|344| Add #include for fprintf [build/include_what_you_use] [4]
src/muntar.h|24| #ifndef header guard has wrong style, please use: SRC_MUNTAR_H_ [build/header_guard] [5]
src/muntar.h|122| #endif line should be "#endif // SRC_MUNTAR_H_" [build/header_guard] [5]
src/tinf.h|24| #ifndef header guard has wrong style, please use: SRC_TINF_H_ [build/header_guard] [5]
src/tinf.h|56| #endif line should be "#endif // SRC_TINF_H_" [build/header_guard] [5]
src/tinfgzip.c|24| Include the directory when naming header files [build/include_subdir] [4]
src/tinflate.c|36| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
src/tinflate.c|37| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
src/tinflate.c|111| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
src/tinflate.c|398| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
src/tinflate.c|411| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Filtered Findings (0)
Annotations
Check warning on line 206 in src/cjit.c
github-actions / cpplint
[cpplint] src/cjit.c#L206
Add #include <cstdio> for fprintf [build/include_what_you_use] [4]
Raw output
src/cjit.c:206: Add #include <cstdio> for fprintf [build/include_what_you_use] [4]
Check warning on line 333 in src/file.c
github-actions / cpplint
[cpplint] src/file.c#L333
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw output
src/file.c:333: Almost always, snprintf is better than strcpy [runtime/printf] [4]
Check warning on line 369 in src/file.c
github-actions / cpplint
[cpplint] src/file.c#L369
If you can, use sizeof(filename) instead of 63 as the 2nd arg to snprintf. [runtime/printf] [3]
Raw output
src/file.c:369: If you can, use sizeof(filename) instead of 63 as the 2nd arg to snprintf. [runtime/printf] [3]
Check warning on line 387 in src/file.c
github-actions / cpplint
[cpplint] src/file.c#L387
If you can, use sizeof(tpath) instead of 259 as the 2nd arg to snprintf. [runtime/printf] [3]
Raw output
src/file.c:387: If you can, use sizeof(tpath) instead of 259 as the 2nd arg to snprintf. [runtime/printf] [3]
Check warning on line 387 in src/file.c
github-actions / cpplint
[cpplint] src/file.c#L387
Add #include <cstdio> for snprintf [build/include_what_you_use] [4]
Raw output
src/file.c:387: Add #include <cstdio> for snprintf [build/include_what_you_use] [4]
Check warning on line 177 in src/muntar.c
github-actions / cpplint
[cpplint] src/muntar.c#L177
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw output
src/muntar.c:177: Almost always, snprintf is better than strcpy [runtime/printf] [4]
Check warning on line 192 in src/muntar.c
github-actions / cpplint
[cpplint] src/muntar.c#L192
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw output
src/muntar.c:192: Almost always, snprintf is better than strcpy [runtime/printf] [4]
Check warning on line 198 in src/muntar.c
github-actions / cpplint
[cpplint] src/muntar.c#L198
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw output
src/muntar.c:198: Almost always, snprintf is better than strcpy [runtime/printf] [4]
Check warning on line 215 in src/muntar.c
github-actions / cpplint
[cpplint] src/muntar.c#L215
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw output
src/muntar.c:215: Almost always, snprintf is better than strcpy [runtime/printf] [4]
Check warning on line 221 in src/muntar.c
github-actions / cpplint
[cpplint] src/muntar.c#L221
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw output
src/muntar.c:221: Almost always, snprintf is better than strcpy [runtime/printf] [4]
Check warning on line 344 in src/muntar.c
github-actions / cpplint
[cpplint] src/muntar.c#L344
Add #include <cstdio> for fprintf [build/include_what_you_use] [4]
Raw output
src/muntar.c:344: Add #include <cstdio> for fprintf [build/include_what_you_use] [4]
Check warning on line 24 in src/muntar.h
github-actions / cpplint
[cpplint] src/muntar.h#L24
#ifndef header guard has wrong style, please use: SRC_MUNTAR_H_ [build/header_guard] [5]
Raw output
src/muntar.h:24: #ifndef header guard has wrong style, please use: SRC_MUNTAR_H_ [build/header_guard] [5]
Check warning on line 122 in src/muntar.h
github-actions / cpplint
[cpplint] src/muntar.h#L122
#endif line should be "#endif // SRC_MUNTAR_H_" [build/header_guard] [5]
Raw output
src/muntar.h:122: #endif line should be "#endif // SRC_MUNTAR_H_" [build/header_guard] [5]
Check warning on line 24 in src/tinf.h
github-actions / cpplint
[cpplint] src/tinf.h#L24
#ifndef header guard has wrong style, please use: SRC_TINF_H_ [build/header_guard] [5]
Raw output
src/tinf.h:24: #ifndef header guard has wrong style, please use: SRC_TINF_H_ [build/header_guard] [5]
Check warning on line 56 in src/tinf.h
github-actions / cpplint
[cpplint] src/tinf.h#L56
#endif line should be "#endif // SRC_TINF_H_" [build/header_guard] [5]
Raw output
src/tinf.h:56: #endif line should be "#endif // SRC_TINF_H_" [build/header_guard] [5]
Check warning on line 24 in src/tinfgzip.c
github-actions / cpplint
[cpplint] src/tinfgzip.c#L24
Include the directory when naming header files [build/include_subdir] [4]
Raw output
src/tinfgzip.c:24: Include the directory when naming header files [build/include_subdir] [4]
Check warning on line 36 in src/tinflate.c
github-actions / cpplint
[cpplint] src/tinflate.c#L36
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Raw output
src/tinflate.c:36: Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Check warning on line 37 in src/tinflate.c
github-actions / cpplint
[cpplint] src/tinflate.c#L37
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Raw output
src/tinflate.c:37: Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Check warning on line 111 in src/tinflate.c
github-actions / cpplint
[cpplint] src/tinflate.c#L111
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Raw output
src/tinflate.c:111: Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Check warning on line 398 in src/tinflate.c
github-actions / cpplint
[cpplint] src/tinflate.c#L398
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Raw output
src/tinflate.c:398: Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Check warning on line 411 in src/tinflate.c
github-actions / cpplint
[cpplint] src/tinflate.c#L411
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Raw output
src/tinflate.c:411: Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]