Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont auto generate last build date #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msathis
Copy link

@msathis msathis commented Sep 23, 2015

I'm not sure whether this is useful for others. In our case we were checking E-Tag header to figure out any feed change. Because this lastBuildDate is auto generated, the E-Tag was always changing though no feed item got changed.

@Mithgol
Copy link
Contributor

Mithgol commented Aug 18, 2016

It seems that the tests should also be changed to pass.

Copy link
Contributor

@alexjorgef alexjorgef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter failed to run due to warnings, if statement should have curly braces.

    if (data.lastBuildDate) {
        channel.push({ lastBuildDate:  data.lastBuildDate });
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants