Better handling of "--" #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the simplest fix I could see for the second part ("Also, and more
importantly...") of dylan-lang#47 ... simply stuff everything after "--" into a new
`unconsumed-arguments` slot in the parser.
While technically this creates a backward incompatibility, the old code resulted in all
the arguments being added to the final option's value list **in reverse order** and it is
highly unlikely that anyone is depending on that broken behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest fix I could see for the second part ("Also, and more importantly...") of #47 ... simply stuff everything after "--" into a new
unconsumed-argumentsslot in the parser.While technically this creates a backward incompatibility, the old code resulted in all the arguments being added to the final option's value list in reverse order and it is highly unlikely that anyone is depending on that broken behavior.
(This should be enough to allow me to make progress on the
deft testcommand, in which I want to be able to pass extra args to testworks withdeft test --build --all -- ...testworks-options....)