feat(bonsai-ui): market header and launchable market details #1400
Conversation
This reverts commit 2b5cd8e.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
changed the title
src/views/MarketStatsDetails.tsx
Outdated
| initialMarginFraction={initialMarginFraction} | ||
| effectiveInitialMarginFraction={effectiveInitialMarginFraction} | ||
| priceChange24HPercent={percentChange24h} | ||
| initialMarginFraction={MustBigNumber(initialMarginFraction).toNumber()} |
There was a problem hiding this comment.
hmm this is slightly awkward, maybe we should do these conversions in the calculators. Any preference?
There was a problem hiding this comment.
I don't think we convert any other market param rn within the calculators. I think I can move the MustBigNumber to the actual render function so that the props can be consistent.
There was a problem hiding this comment.
yeah I don't have a super preference. If we end up doing this kind of parsing in multiple places though it might be worth just adding it to some calculators
| initialMarginFraction: number | null | undefined; | ||
| effectiveInitialMarginFraction: number | null | undefined; | ||
| initialMarginFraction: string | null | undefined; | ||
| effectiveInitialMarginFraction: BigNumber | null | undefined; |
There was a problem hiding this comment.
yeah I suppose this is okay for now but this object is a mess. We need to make it consistent soonish, all numbers should either be number or bignumber.
Migrate market headers and details
Views
<LaunchableMarketStatsDetails>&<LaunchableMarketDetails><MarketStatsDetails>Functions/Clients
lib/ontology