-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(funding) Add defaultFunding8hrPpm
field to Perpetual Create/Update indexer events
#2674
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
defaultFunding8hrPpm
field to perpetual indexer eventsdefaultFunding8hrPpm
field to perpetual create and update indexer events
defaultFunding8hrPpm
field to perpetual create and update indexer eventsdefaultFunding8hrPpm
field to Perpetual Create/Update indexer events
defaultFunding8hrPpm
field to Perpetual Create/Update indexer eventsdefaultFunding8hrPpm
field to Perpetual Create/Update indexer events
defaultFunding8hrPpm
field to Perpetual Create/Update indexer eventsdefaultFunding8hrPpm
field to Perpetual Create/Update indexer events
|
||
// Since: v8.x | ||
// Default 8hr funding rate in parts-per-million. | ||
int32 default_funding8hr_ppm = 12; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Instead of Harry's approach which creates a new V2 message type, simply add the field which is non-breaking. The event handler just needs handle the case when the field is absent.
8773aa9
to
c29878d
Compare
f2754f1
to
a5349cd
Compare
CT-1340
Changelist
DefaultFundingRate1H
PerpetualMarketCreateEvent
andUpdatePerpetualEvent
, addDefaultFunding8hrPpm
. In handlers, convert these ppm into 1hr funding rate and store in DB.Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.