Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix problematic const name and some typos in comment #2621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol/app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ func New(
transferModule := transfer.NewAppModule(app.TransferKeeper)
transferIBCModule := transfer.NewIBCModule(app.TransferKeeper)

// Wrap the x/ratelimit middlware over the IBC Transfer module
// Wrap the x/ratelimit middleware over the IBC Transfer module
var transferStack ibcporttypes.IBCModule = transferIBCModule
transferStack = ratelimitmodule.NewIBCMiddleware(app.RatelimitKeeper, transferStack)

Expand Down
2 changes: 1 addition & 1 deletion protocol/app/flags/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func AddFlagsToCmd(cmd *cobra.Command) {

// Validate checks that the flags are valid.
func (f *Flags) Validate() error {
// Validtors must have cosmos grpc services enabled.
// Validators must have cosmos grpc services enabled.
if !f.NonValidatingFullNode && !f.GrpcEnable {
return fmt.Errorf("grpc.enable must be set to true - validating requires gRPC server")
}
Expand Down
2 changes: 1 addition & 1 deletion protocol/app/process/default_market_price_decoder.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
// This implementation is expected to default MarketPriceUpdates in accordance with the dydx process-proposal
// logic pre vote-extensions
type DefaultUpdateMarketPriceTxDecoder struct {
// pk is the expecte dependency on x/prices keeper, used for stateful validation of the returned MarketPriceUpdateTx
// pk is the expected dependency on x/prices keeper, used for stateful validation of the returned MarketPriceUpdateTx
pk ProcessPricesKeeper

// tx decoder used for unmarshalling the market-price-update tx
Expand Down
2 changes: 1 addition & 1 deletion protocol/app/upgrades/v4.0.0/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var Upgrade = upgrades.Upgrade{
// Add new ICA stores that are needed by ICA host types as of v8.
icacontrollertypes.StoreKey,

// Add authz module to allow granting arbitrary privileges from one account to another acocunt.
// Add authz module to allow granting arbitrary privileges from one account to another account.
authzkeeper.StoreKey,
},
},
Expand Down
2 changes: 1 addition & 1 deletion protocol/cmd/dydxprotocold/cmd/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const (
// the chain stake token. It's also recommended that the min gas price in stake token
// is roughly the same in value as 0.025 micro USDC.
minGasPriceStakeToken = "25000000000adv4tnt"
// `minGasPrice` defines the default `minimum-gas-prices` attribute in validator's `app.toml` file.
// `MinGasPrice` defines the default `minimum-gas-prices` attribute in validator's `app.toml` file.
MinGasPrice = minGasPriceUusdc + "," + minGasPriceStakeToken
)

Expand Down
2 changes: 1 addition & 1 deletion protocol/x/assets/types/constants.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package types

const (
// MaxAssetSymbolLength is the maximum exponent for a asset/coin unit
// MaxAssetUnitExponentAbs is the maximum exponent for a asset/coin unit
// (e.g. DenomExponent, AtomicResolution)
MaxAssetUnitExponentAbs = 32
)
2 changes: 1 addition & 1 deletion protocol/x/ratelimit/ibc_middleware.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type IBCMiddleware struct {
keeper keeper.Keeper
}

// TODO(CORE-855): Add e2e testing for the x/ratelimit IBC Middlware
// TODO(CORE-855): Add e2e testing for the x/ratelimit IBC Middleware
func NewIBCMiddleware(k keeper.Keeper, app porttypes.IBCModule) IBCMiddleware {
return IBCMiddleware{
app: app,
Expand Down