-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make PML compatible with OE by staging in-memory CLOB side effects (backport #2447) #2459
feat: make PML compatible with OE by staging in-memory CLOB side effects (backport #2447) #2459
Conversation
Cherry-pick of 161c34d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Changelist
PML supports user transaction that creates new ClobPair (both in state and in memory objects). Currently there are two issues:
To solve these issues we use the
FinalizeBlockEventStager
to store aClobPair
creation event duringDeliverTx
, and apply the in-memory side effects later inPrecommit
.Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
New Features
ClobStagedFinalizeBlockEvent
interface for handling CLOB events during block finalization.ClobStagedFinalizeBlockEvent
message type.Precommit
function to process staged finalize block events.Changes
CreatePerpetualClobPairAndMemStructs
functionality.Bug Fixes
MaybeCreateOrderbook
method to prevent potential issues.This is an automatic backport of pull request #2447 done by [Mergify](https://mergify.com).