Fix broken proto/e2e/lint workflows #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyding
commented
Sep 30, 2024
| @@ -1,13 +0,0 @@ | |||
| build: | |||
There was a problem hiding this comment.
Delete buf.yaml under root, in favor of proto/buf.yaml
teddyding
force-pushed
the
td/fix-comet-ci
branch
3 times, most recently
from
f40fab5 to
2fc5a0d
Compare
teddyding
commented
Oct 1, 2024
| @@ -120,8 +120,8 @@ mockery: | |||
|
|
|||
| #? check-proto-deps: Check protobuf deps | |||
| check-proto-deps: | |||
| ifeq (,$(shell which protoc-gen-gogofaster)) | |||
| @go install github.com/cosmos/gogoproto/protoc-gen-gogofaster@latest | |||
| ifeq (,$(shell which protoc-gen-gocosmos)) | |||
There was a problem hiding this comment.
gogofaster is outdated. gocosmos is used by latest
teddyding
commented
Oct 1, 2024
| @@ -2,9 +2,7 @@ syntax = "proto3"; | |||
| package dydxcometbft.clob; | |||
|
|
|||
| import "gogoproto/gogo.proto"; | |||
| import "cosmos_proto/cosmos.proto"; | |||
teddyding
force-pushed
the
td/fix-comet-ci
branch
from
7a8e25c to
7be6e39
Compare
vincentwschau
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proto/e2e/lint workflows that have been broken for a while. All changes in this PR should be discarded once we sync up to latest
cometbftversions.