Add an software override (1sec) for TimeoutPropose
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Network experiences a
~5sec
block time when a proposer is offline/severely lagging behind. This is due to the current software default,TimeoutPropose = 3s
, which means that when a proposer is unavailable, we spend 3s waiting for the proposal + 0.5s for round 0 prevote/precommit, so~3.5s
more than an average block.This software default of
3s
was not conscious, and could've been updated along whentimeout_commit
was reduced to500ms
.See attached block dump during a period when 2 small validators went offline, and 4% of the blocks have elevated >5sec blocks. As a result, average block time is much higher than median block time during this period:
Solution
Add a software override for
TimeoutPropose
to1s
. This should be more than enough for a block where proposer is present. . This reduces p99 and average block time.This requires a coordinated upgrade to maintain synchrony among validators.
PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments