Added and improved coverage to tests + fixed vulnerabilities

.github/workflows/build.yml

@@ -1,6 +1,6 @@
 name: Build Working Version
 
-on: push
+on: pull_request
 
 jobs:
   build:

lib/jest.config.cjs

@@ -3,14 +3,14 @@ module.exports = {
   coverageThreshold: {
     global: {
       // global thresholds
-      branches: 20,
-      functions: 20,
-      lines: 20,
-      statements: 20,
+      branches: 50,
+      functions: 50,
+      lines: 80,
+      statements: 80,
     },
   },
   collectCoverage: true,
-  collectCoverageFrom: ["**/src/**/*.{js}", "!**/node_modules/**", "!**/coverage/**", "!**/test/**"],
+  collectCoverageFrom: ["src/*.js", "src/**/*.js", "!src/main.js", "!**/node_modules/**"],
   testURL: "http://localhost",
   testEnvironment: "jsdom",
   transform: {

lib/package.json

@@ -13,9 +13,9 @@
     "copy": "node ./scripts/build/copy-distribution-files.js",
     "start": "rollup -c -w",
     "build": "npm run bundle && npm run copy",
-    "test": "jest --transformIgnorePatterns node_modules/?!axios/",
-    "test:watch": "npm test -- --watch --coverage",
-    "test:coverage": "npm test -- --coverage --coverageReporters=cobertura",
+    "test": "jest --collect-coverage --transformIgnorePatterns node_modules/?!axios/",
+    "test:watch": "npm test --watch --coverage",
+    "test:coverage": "npm test --collect-coverage --coverageReporters=cobertura",
     "test:coverage-dashboard": "npm test --collect-coverage"
   },
   "author": "DXC Halstack team",

lib/test/hal-api-caller.test.js

@@ -1,11 +1,12 @@
-import axios from 'axios';
-import MockAdapter from 'axios-mock-adapter';
+import axios from "axios";
+import MockAdapter from "axios-mock-adapter";
 
 // Import the function to be tested
-import apicaller from '../src/hal-api-caller';
-import response from './mocks/options-response.json';
+import apicaller from "../src/hal-api-caller";
+import optionsResponse from "./mocks/options-response.json";
+import getResponse from "./mocks/get-response.json";
 
-describe('options function', () => {
+describe("Apicaller functions test", () => {
   let mockAxios;
 
   beforeEach(() => {
@@ -16,16 +17,11 @@ describe('options function', () => {
     mockAxios.restore();
   });
 
-  it('should make a successful OPTIONS request and return HalResponse', async () => {
-    const url = 'https://example.com';
-    const headers = { CustomHeader: 'CustomValue' };
-    const responseData = response;
-    const responseHeaders = { 'Content-Type': 'application/json' };
-    const expectedHalResponse = {
-      body: { _options: responseData },
-      headers: responseHeaders,
-      status: 200,
-    };
+  it("should make a successful OPTIONS request and return HalResponse", async () => {
+    const url = "https://example.com";
+    const headers = { CustomHeader: "CustomValue" };
+    const responseData = optionsResponse;
+    const responseHeaders = { "Content-Type": "application/json" };
 
     // Mocking the Axios request and response
     mockAxios.onOptions(url).reply(200, responseData, responseHeaders);
@@ -34,9 +30,26 @@ describe('options function', () => {
     const result = await apicaller.options({ url, headers });
 
     // Assertions
+    expect(result).toBeDefined();
+    expect(result.halResource).toBeDefined();
+    expect(result.halResource.getTitle()).toEqual("Options available on Quote ID");
+  });
 
+  it("should make a successful GET request and return HalResponse", async () => {
+    const url = "https://example.com";
+    const headers = { CustomHeader: "CustomValue" };
+    const responseData = getResponse;
+    const responseHeaders = { "Content-Type": "application/json" };
+
+    // Mocking the Axios request and response
+    mockAxios.onGet(url).reply(200, responseData, responseHeaders);
+
+    // Calling the function
+    const result = await apicaller.get({ url, headers });
+
+    // Assertions
     expect(result).toBeDefined();
     expect(result.halResource).toBeDefined();
-    expect(result.halResource.getTitle()).toEqual('Options available on Quote ID');
+    expect(result.halResource.getItems().length).toBe(10);
   });
 });