extract selenium install logic to a module #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before all: thanks you for this cool repo. It helped me a lot configuring nightwatch in a real project 👍
Currently, the whole
nightwatch.conf.js
is set as apostinstall
hook inpackage.json
. But the only reason to do that -as far as I understand- is to ensure that selenium gets downloaded. This is pretty misleading since people just copypasting the configuration object fromnightwatch.conf.js
to their own config file as a template would not get the tests to run, since selenium would not be downloaded.Also, this way is just more clear what the
postinstall
hook is about.Since now both the config files and the
selenium-install.js
module need theBINPATH
, constants were also refactored to a common module.