Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Type: getUploadDir could not be null #1421

Closed
wants to merge 2 commits into from
Closed

Fix Type: getUploadDir could not be null #1421

wants to merge 2 commits into from

Conversation

RobinDev
Copy link

No description provided.

garak
garak requested changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the reason for this change. Even if there's one, CI is failing

@RobinDev
Copy link
Author

RobinDev commented Dec 22, 2023 •
edited
Loading

Reason : avoid having to ignore the static analysis error or to do a useless string cast.

Normally, I fix the CI and if you think this pr is useless, it's okay for closing it.

@garak
Copy link
Collaborator

garak commented Feb 4, 2024

bump

@garak
Copy link
Collaborator

garak commented Jun 23, 2024

I'm sorry but I have to close this, it's too old and has no feedback.

@garak garak closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garak garak garak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinDev @garak