Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Make VichImageType class extensible by removing 'final' #1406

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Refactor: Make VichImageType class extensible by removing 'final' #1406

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2714f13
Refactor: Make VichImageType class extensible by removing 'final'
gunyar Nov 5, 2023
9ae1cfb
Include 'accept' option in default attributes for VichImageType
gunyar Nov 9, 2023
705c3e0
Merge branch 'master' into update-form-type
gunyar Nov 9, 2023
6266380
Update 'accept' attribute to 'image/*' for broader format support in …
Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Form/Type/VichImageType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* @author Konstantin Myakshin <[email protected]>
* @author Massimiliano Arione <[email protected]>
*/
final class VichImageType extends VichFileType
class VichImageType extends VichFileType
{
public const STORAGE_RESOLVE_URI = 0;

Expand All @@ -43,6 +43,9 @@ public function configureOptions(OptionsResolver $resolver): void
'image_uri' => true,
'imagine_pattern' => null,
'storage_resolve_method' => self::STORAGE_RESOLVE_URI,
'attr' => [
'accept' => 'image/*',
],
]);

$resolver->setAllowedValues(
Expand Down